add subpath spec for volume claim mounts#97
Merged
amitschang merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for mounting a PVC at a specific subdirectory (Kubernetes subPath) in the FileService deployment Helm template, enabling use of PVCs where the desired content is not at the volume root.
Changes:
- Add an optional
subPathfield to FileService PVC-basedvolumeMountsdriven by.Values.fileservice.pvcVolumes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -99,6 +99,9 @@ spec: | |||
| {{- range $key, $val := .Values.fileservice.pvcVolumes }} | |||
| - name: {{ $key }} | |||
| mountPath: {{ $val.mountPath }} | |||
There was a problem hiding this comment.
The chart now supports .Values.fileservice.pvcVolumes[*].subPath, but the values.yaml example/comment block for fileservice.pvcVolumes doesn’t mention this field. Please update the chart’s values documentation (e.g., helm/sciserver/values.yaml and any user docs) to include subPath, so operators can discover/configure it correctly.
Suggested change
| mountPath: {{ $val.mountPath }} | |
| mountPath: {{ $val.mountPath }} | |
| {{- /* Optional: set .Values.fileservice.pvcVolumes[<name>].subPath to mount a sub-directory of the PVC */ -}} |
dmedv
approved these changes
Mar 26, 2026
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for some pvcs where we mount from a subpath instead of root